Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5 ➡️ 6 (main) #155

Merged
merged 6 commits into from
Apr 21, 2022
Merged

5 ➡️ 6 (main) #155

merged 6 commits into from
Apr 21, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-launch5 to main.

Branch comparison: main...ign-launch5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

adityapande-1995 and others added 6 commits February 24, 2022 11:51
@adityapande-1995
Expose headless_rendering sdf tag (#148)
b63eb2e 
Signed-off-by: Aditya <[email protected]>
@azeey
Use exec instead of popen to run ign-launch binary (#151)
909e856 
Currently, the ruby processes creates a new process to run the ign-launch binary. Signals sent to the ruby processes don't propagate to the child process which causes problems during shutdown. The solution here is to replace the ruby process with the ign-launch process using exec.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@adityapande-1995
5.1.0 (#152)
7dbac66 
* 5.1.0
Signed-off-by: Aditya <[email protected]>
@chapulina
Depend on python3-yaml instead of python-yaml (#153)
9cbc15e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Add Ubuntu Jammy CI (#154)
8c78b6c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
5 ➡️ 6 (main)
50ed180 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from nkoenig as a code owner April 8, 2022 23:40
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 8, 2022
@chapulina chapulina requested a review from j-rivero April 8, 2022 23:40
@chapulina chapulina mentioned this pull request Apr 8, 2022
Closed
@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #155 (7136a2d) into main (f40d7a7) will not change coverage.
The diff coverage is n/a.

❗ Current head 7136a2d differs from pull request most recent head 50ed180. Consider uploading reports for the commit 50ed180 to get more accurate results

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files           4        4           
  Lines         817      817           
=======================================
  Hits          269      269           
  Misses        548      548

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40d7a7...50ed180. Read the comment docs.

@mjcarroll
Copy link
Contributor

I believe windows is expected, but homebrew is giving:

CMake Error at /usr/local/share/cmake/pybind11/pybind11NewTools.cmake:207 (python3_add_library):
  Unknown CMake command "python3_add_library".
Call Stack (most recent call first):
  python/CMakeLists.txt:39 (pybind11_add_module)

@chapulina chapulina mentioned this pull request Apr 11, 2022
Merged
@scpeters
Copy link
Member

I believe windows is expected, but homebrew is giving:

CMake Error at /usr/local/share/cmake/pybind11/pybind11NewTools.cmake:207 (python3_add_library):
  Unknown CMake command "python3_add_library".
Call Stack (most recent call first):
  python/CMakeLists.txt:39 (pybind11_add_module)

retrying homebrew now that osrf/homebrew-simulation#1870 has been merged

@chapulina
Copy link
Contributor Author

chapulina commented Apr 15, 2022 •
edited
Loading

Homebrew is still unhappy, I don't think that's introduced by this PR though

Fixed

@chapulina chapulina merged commit 8b2b569 into main Apr 21, 2022
@chapulina chapulina deleted the chapulina/5_to_6 branch April 21, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@nkoenig nkoenig nkoenig approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

Assignees

@chapulina chapulina

Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chapulina @mjcarroll @scpeters @nkoenig @adityapande-1995 @azeey